Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Gurjeet Singh <gurjeet(at)singh(dot)im>
Cc: pgsql-hackers(at)postgresql(dot)org, tgl(at)sss(dot)pgh(dot)pa(dot)us
Subject: Re: harmonize password reuse in vacuumdb, clusterdb, and reindexdb
Date: 2023-07-28 17:14:29
Message-ID: 20230728171429.GA3764457@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Wed, Jul 19, 2023 at 10:43:11AM -0700, Nathan Bossart wrote:
> On Wed, Jun 28, 2023 at 10:24:09PM -0700, Nathan Bossart wrote:
>> The same commit that added this comment (ff402ae) also set the
>> allow_password_reuse parameter to true in vacuumdb's connectDatabase()
>> calls. I found a message from the corresponding thread that provides some
>> additional detail [0]. I wonder if this comment should instead recommend
>> against using the allow_password_reuse flag unless reconnecting to the same
>> host/port/user target. Connecting to different databases with the same
>> host/port/user information seems okay. Maybe I am missing something...
> I added Tom here since it looks like he was the original author of this
> comment. Tom, do you have any concerns with updating the comment for
> connectDatabase() in src/fe_utils/connect_utils.c like this?

I went ahead and committed this. I'm happy to revisit if there are

Nathan Bossart
Amazon Web Services:

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Vik Fearing 2023-07-28 17:19:21 Re: New PostgreSQL Contributors
Previous Message Christoph Berg 2023-07-28 15:29:38 New PostgreSQL Contributors