Re: Allow pg_archivecleanup to remove backup history files

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: torikoshia(at)oss(dot)nttdata(dot)com
Cc: michael(at)paquier(dot)xyz, masao(dot)fujii(at)oss(dot)nttdata(dot)com, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Allow pg_archivecleanup to remove backup history files
Date: 2023-06-21 02:59:41
Message-ID: 20230621.115941.1395557545366586431.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 20 Jun 2023 22:27:36 +0900, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> wrote in
> On 2023-06-19 14:37, Michael Paquier wrote:
> > On Mon, Jun 19, 2023 at 11:24:29AM +0900, torikoshia wrote:
> >> Thanks, now I understand what you meant.
> > If I may ask, why is the refactoring of 0003 done after the feature in
> > 0002? Shouldn't the order be reversed? That would make for a cleaner
> > git history.
> > --
> > Michael
>
> Agreed.
> Reversed the order of patches 0002 and 0003.

Yeah, that is a possible division. However, I meant that we have room
to refactor and decrease the nesting level even further, considering
that 0003 already does this to some extent, when I suggested it. In
that sense, moving the nest-reduction part of 0003 into 0002 makes us
possible to focus on the point of this patch.

What do you think about the attached version?

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

Attachment Content-Type Size
v10-0001-Introduce-pg_archivecleanup-into-getopt_long.patch text/x-patch 4.0 KB
v10-0002-Preliminary-refactoring-for-a-subsequent-patch.patch text/x-patch 5.8 KB
v10-0003-Allow-pg_archivecleanup-to-remove-backup-history.patch text/x-patch 8.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-06-21 03:24:48 Re: could not extend file "base/5/3501" with FileFallocate(): Interrupted system call
Previous Message Michael Paquier 2023-06-21 02:53:44 Remove deprecation warnings when compiling PG ~13 with OpenSSL 3.0~