Re: BUG #17942: vacuumdb doesn't populate extended statistics on partitioned tables

At Wed, 24 May 2023 06:41:23 +0000, PG Bug reporting form <noreply(at)postgresql(dot)org> wrote in
> vacuumdb -Z -t people : -> ok extende stats collected
> vacuumdb -Z : -> no extended stats and analyze much faster

ANALYZE processes inhertance parents. By a quick search, I found that commit 3c3bb99330 modified get_rel_oids (which has now been relocated to get_all_vacuum_rels) to include RELKIND_PARTITIONED_TABLE. However, it seems like it overlooked updating the same in vacuumdb.c. This dates back to 10.

diff --git a/src/bin/scripts/vacuumdb.c b/src/bin/scripts/vacuumdb.c
index 4b17a07089..1369c37504 100644
--- a/src/bin/scripts/vacuumdb.c
+++ b/src/bin/scripts/vacuumdb.c
@@ -686,7 +686,8 @@ vacuum_one_database(ConnParams *cparams,
{
appendPQExpBufferStr(&catalog_query, " WHERE c.relkind OPERATOR(pg_catalog.=) ANY (array["
CppAsString2(RELKIND_RELATION) ", "
- CppAsString2(RELKIND_MATVIEW) "])\n");
+ CppAsString2(RELKIND_MATVIEW) ", "
+ CppAsString2(RELKIND_PARTITIONED_TABLE) "])\n");
has_where = true;
}

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center