Re: check_GUC_init(wal_writer_flush_after) fails with non-default block size

From: Andres Freund <andres(at)anarazel(dot)de>
To: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: check_GUC_init(wal_writer_flush_after) fails with non-default block size
Date: 2023-04-08 05:21:03
Message-ID: 20230408052103.cm3l6xq7qr7b63ib@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-04-08 13:18:55 +1200, Thomas Munro wrote:
> If you build with --with-wal-blocksize=/-Dwal_blocksize= anything but
> 8, this breaks:
>
> running bootstrap script ... LOG: GUC (PGC_INT)
> wal_writer_flush_after, boot_val=256, C-var=128
> TRAP: failed Assert("check_GUC_init(hentry->gucvar)"), File: "guc.c",
> Line: 1519, PID: 84605

> From 48d971e0b19f770991e334b8dc38422462b4485e Mon Sep 17 00:00:00 2001
> From: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
> Date: Sat, 8 Apr 2023 13:12:48 +1200
> Subject: [PATCH] Fix default wal_writer_flush_after value.

LGTM.

Greetings,

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2023-04-08 05:34:53 Re: Non-superuser subscription owners
Previous Message Tom Lane 2023-04-08 05:03:25 Re: Direct I/O