| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Daniel Gustafsson <daniel(at)yesql(dot)se>, Andrew Dunstan <andrew(at)dunslane(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, mikael(dot)kjellstrom(at)gmail(dot)com |
| Subject: | Re: Making background psql nicer to use in tap tests |
| Date: | 2023-04-08 00:57:33 |
| Message-ID: | 20230408005733.rlzh55eh5beq6kfn@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-07 20:49:39 -0400, Tom Lane wrote:
> I wrote:
> > I've been doing some checking with perlbrew locally. It appears to not
> > be about IO::Pty so much as IPC::Run: it works with IPC::Run 0.99 but
> > not 0.79. Still bisecting to identify exactly what's the minimum
> > okay version.
>
> The answer is: it works with IPC::Run >= 0.98. The version of IO::Pty
> doesn't appear significant; it works at least back to 1.00 from early
> 2002.
>
> IPC::Run 0.98 is relatively new (2018), so I don't think it'd fly
> to make that our new minimum version across-the-board. I recommend
> just setting up this one test to SKIP if IPC::Run is too old.
Does the test actually take a while before it fails, or is it quick? It's
possible the failure is caused by 001_password.pl's use of
set_query_timer_restart(). I don't think other tests do something quite
comparable.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-04-08 01:04:22 | Re: Making background psql nicer to use in tap tests |
| Previous Message | Tom Lane | 2023-04-08 00:49:39 | Re: Making background psql nicer to use in tap tests |