| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Yura Sokolov <y(dot)sokolov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: refactoring relation extension and BufferAlloc(), faster COPY |
| Date: | 2023-04-05 00:32:03 |
| Message-ID: | 20230405003203.xd333lzfb2fodoqr@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-03-30 12:28:57 +0700, John Naylor wrote:
> On Thu, Mar 30, 2023 at 10:02 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > Attached is v6. Changes:
>
> 0006:
>
> + ereport(ERROR,
> + errcode_for_file_access(),
> + errmsg("could not extend file \"%s\" with posix_fallocate():
> %m",
> + FilePathName(v->mdfd_vfd)),
> + errhint("Check free disk space."));
>
> Portability nit: mdzeroextend() doesn't know whether posix_fallocate() was
> used in FileFallocate().
Fair point. I would however like to see a different error message for the two
ways of extending, at least initially. What about referencing FileFallocate()?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-04-05 00:33:25 | Re: Minimal logical decoding on standbys |
| Previous Message | Peter Smith | 2023-04-05 00:29:09 | Comment typo in recent push |