| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Subject: | Re: Making background psql nicer to use in tap tests |
| Date: | 2023-04-02 21:37:58 |
| Message-ID: | 20230402213758.dkh6exwrh2ehu4oh@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-04-02 22:24:16 +0200, Daniel Gustafsson wrote:
> And a v5 to fix a test failure in recovery tests.
Thanks for workin gon this!
There's this XXX that I added:
> @@ -57,11 +51,10 @@ sub test_streaming
> COMMIT;
> });
>
> - $in .= q{
> - COMMIT;
> - \q
> - };
> - $h->finish; # errors make the next test fail, so ignore them here
> + $h->query_safe('COMMIT');
> + $h->quit;
> + # XXX: Not sure what this means
> + # errors make the next test fail, so ignore them here
>
> $node_publisher->wait_for_catchup($appname);
I still don't know what that comment is supposed to mean, unfortunately.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-04-02 22:15:44 | Re: Minimal logical decoding on standbys |
| Previous Message | Tom Lane | 2023-04-02 21:36:30 | Re: Infinite Interval |