| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Refactor calculations to use instr_time |
| Date: | 2023-03-30 21:25:24 |
| Message-ID: | 20230330212524.yz2chdxl6iyugbme@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
I pushed this version! Thanks all, for the contribution and reviews.
> > I would either put WalUsage into PgStat_PendingWalStats (so that it has
> > all the same members as PgStat_WalStats), or figure out a way to
> > maintain WalUsage separately from PgStat_WalStats or something else.
> > Worst case, add more comments to the struct definitions to explain why
> > they have the members they have and how WalUsage relates to them.
>
> Yes, but like Andres said this could be better done as a separate patch.
I invite you to write a patch for that for 17...
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-03-30 21:33:48 | Re: Thoughts on using Text::Template for our autogenerated code? |
| Previous Message | Jeff Davis | 2023-03-30 21:15:29 | Re: ICU locale validation / canonicalization |