Re: what should install-world do when docs are not available?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, Justin Pryzby <pryzby(at)telsasoft(dot)com>
Subject: Re: what should install-world do when docs are not available?
Date: 2023-03-29 22:41:32
Message-ID: 20230329224132.fnymznyxmta5ugrs@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-03-29 18:39:27 +0200, Peter Eisentraut wrote:
> On 29.03.23 18:25, Andres Freund wrote:
> > On 2023-03-29 18:15:02 +0200, Peter Eisentraut wrote:
> > > On 25.03.23 21:14, Andres Freund wrote:
> > > > I wonder if, for meson, the best behaviour would be to make 'docs' a feature
> > > > set to auto. If docs set to enabled, and the necessary tools are not
> > > > available, fail at that time, instead of doing so while building.
> > >
> > > Makes sense to me.
> > >
> > > > If that's what we decide to do, perhaps "docs" should be split further? The
> > > > dependencies for pdf generation are a lot more heavyweight.
> > >
> > > I think "docs" should be html and man, because that's what gets installed.
> > >
> > > pdf and other things can just be an ad hoc build target and doesn't need
> > > install support.
> >
> > I just meant for feature detection.
>
> Ah yes, then things like fop should either be a separate feature or just do
> something light weight, like failing the target if fop isn't there.

Attached is an implementation of this approach. This includes some lightly
polished patches from [1] and a new patch to remove htmlhelp.

Greetings,

Andres Freund

[1] https://postgr.es/m/3fc3bb9b-f7f8-d442-35c1-ec82280c564a%40enterprisedb.com

Attachment Content-Type Size
v4-0001-doc-Remove-support-for-htmlhelp-format.patch text/x-diff 4.4 KB
v4-0002-meson-docs-Preparatory-cleanups.patch text/x-diff 4.5 KB
v4-0003-meson-add-docs-docs_pdf-options.patch text/x-diff 7.1 KB
v4-0004-docs-html-copy-images-to-output-as-part-of-xslt-b.patch text/x-diff 2.4 KB
v4-0005-docs-load-stylesheet-via-custom.css.source.patch text/x-diff 4.2 KB
v4-0006-meson-docs-Allow-configuring-simple-website-style.patch text/x-diff 2.4 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2023-03-29 22:51:01 Re: what should install-world do when docs are not available?
Previous Message Justin Pryzby 2023-03-29 21:48:19 Re: Temporary tables versus wraparound... again