| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | michael(at)paquier(dot)xyz |
| Cc: | bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pg(at)bowt(dot)ie, melanieplageman(at)gmail(dot)com, boekewurm+postgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Add pg_walinspect function with block info columns |
| Date: | 2023-03-27 03:41:46 |
| Message-ID: | 20230327.124146.1275500402030502817.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Sat, 25 Mar 2023 12:12:50 +0900, Michael Paquier <michael(at)paquier(dot)xyz> wrote in
> On Thu, Mar 23, 2023 at 10:54:40PM +0530, Bharath Rupireddy wrote:
> OUT reltablespace oid,
> OUT reldatabase oid,
> OUT relfilenode oid,
> OUT relblocknumber int8,
> + OUT blockid int2,
> + OUT start_lsn pg_lsn,
> + OUT end_lsn pg_lsn,
> + OUT prev_lsn pg_lsn,
>
> I'd still put the LSN data before the three OIDs for consistency with
> the structures, though my opinion does not seem to count much..
I agree with Michael on this point. Also, although it may not be
significant for SQL, the rows are output in lsn order from the
function.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | vignesh C | 2023-03-27 03:57:48 | Re: Support logical replication of DDLs |
| Previous Message | Kirk Wolak | 2023-03-27 03:36:10 | Re: possible proposal plpgsql GET DIAGNOSTICS oid = PG_ROUTINE_OID |