Re: doc: add missing "id" attributes to extension packaging page

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com>
Cc: Brar Piening <brar(at)gmx(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, vignesh C <vignesh21(at)gmail(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: doc: add missing "id" attributes to extension packaging page
Date: 2023-03-23 09:35:55
Message-ID: 20230323093555.3icw7zetwtmtrrzu@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks, Brar and Karl, I hope we can get this done soon.

As with the <simplelist> patch, we'll need to patch the CSS used in the
website for the docs too, as that's the most important place where docs
are visited. See this commit for an example:
https://git.postgresql.org/gitweb/?p=pgweb.git;a=commitdiff;h=0b89ea0fff28d29ed177c82a274144453e3c7f82

In order to test locally that your patched stylesheet works correctly,
you'd have to compile the docs with "make html STYLE=website" in the doc
subdir, and tweak one of the CSS files there (I think it's
docs-complete.css) so that it references your local copy instead of
fetching it from the website.

> diff --git a/doc/src/sgml/stylesheet.css b/doc/src/sgml/stylesheet.css
> index cc14efa1ca..15bcc95d41 100644
> --- a/doc/src/sgml/stylesheet.css
> +++ b/doc/src/sgml/stylesheet.css
> @@ -169,3 +169,13 @@ acronym { font-style: inherit; }
> width: 75%;
> }
> }
> +
> +/* Links to ids of headers and definition terms */
> +a.id_link {
> + color: inherit;
> + visibility: hidden;
> +}
> +
> +*:hover > a.id_link {
> + visibility: visible;
> +}

I'm not clear on what exactly becomes visible when one hovers over what.
Can you please share a screenshot?

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2023-03-23 09:45:51 Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Previous Message Peter Smith 2023-03-23 09:21:47 Re: add log messages when replication slots become active and inactive (was Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?)