Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences

From: "Karl O(dot) Pinc" <kop(at)karlpinc(dot)com>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Greg Stark <stark(at)mit(dot)edu>, "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, w^3 <pgsql-www(at)lists(dot)postgresql(dot)org>
Subject: Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences
Date: 2023-03-15 13:55:21
Message-ID: 20230315085521.1455aeb1@slate.karlpinc.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-www

On Wed, 15 Mar 2023 09:41:27 +0100
Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:

> Actually, the 0001 patch hadn't been fully committed yet ... I had
> only added the CSS tweaks. I have now pushed the addition of the
> tables to the SGML sources, with minor tag changes: I found that with
> the <simplelist> outside of any <para>, the list was too close to the
> next paragraph, which looked a bit ugly. I put the list inside the
> <para> that explains what the list is. It looks good with PDF,
> website-HTML and plain-HTML rendering now; didn't look at other
> output formats. So, the CF entry being marked committed is now
> correct as far as I'm concerned.

Thanks for noticing that. (I'd always vaguely wondered about
lists being inside v.s. outside of paragraphs. There must be other
places in the docs where this matters. ?)

> > There remains an un-committed patch from this thread/commitfest
> > entry:
>
> > diff --git a/doc/src/sgml/stylesheet-fo.xsl
> > b/doc/src/sgml/stylesheet-fo.xsl index 0c4dff92c4..68a46f9e24 100644
> > --- a/doc/src/sgml/stylesheet-fo.xsl
> > +++ b/doc/src/sgml/stylesheet-fo.xsl
>
> > +<!-- Every sect1 in the contrib appendix gets a page break -->
> > +<xsl:template match="id('contrib')/sect1">
> > + <fo:block break-after='page'/>
> > + <xsl:apply-imports/>
> > +</xsl:template>
>
> Yeah, I think this one achieves what I wanted and isn't a maintenance
> burden, but I would like to hear from other CSS people. I guess I
> could just commit it and see what complaints I get (probably none).

FWIW, this patch is not to CSS. It's XSLT and affects only the PDF
generation.

(The patch is a response to your "aside" and remarks regarding a
separate thread, here:
https://www.postgresql.org/message-id/20230118173447.aegjdk3girgkqu2g%40alvherre.pgsql
)

Regards,

Karl <kop(at)karlpinc(dot)com>
Free Software: "You don't pay back, you pay forward."
-- Robert A. Heinlein

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ankit Kumar Pandey 2023-03-15 14:01:46 Re: optimize several list functions with SIMD intrinsics
Previous Message Alexander Lakhin 2023-03-15 12:59:59 Re: windows CI failing PMSignalState->PMChildFlags[slot] == PM_CHILD_ASSIGNED

Browse pgsql-www by date

  From Date Subject
Next Message Soporte POSTGRES Canarias 2023-03-16 15:53:09 Questions
Previous Message Alvaro Herrera 2023-03-15 08:41:27 Re: Doc: Rework contrib appendix -- informative titles, tweaked sentences