Re: buildfarm + meson

Hi,

On 2023-03-08 09:41:57 -0500, Andrew Dunstan wrote:
> On 2023-03-08 We 08:57, Andrew Dunstan wrote:
> > On 2023-03-07 Tu 20:29, Andres Freund wrote:
> > > On 2023-03-07 15:47:54 -0500, Andrew Dunstan wrote:
> > > Here's a prototype for that.
> > >
> > > It adds an install-test-files target, Because we want to install into a normal
> > > directory, I removed the necessary munging of the target paths from
> > > meson.build and moved it into install-test-files. I also added DESTDIR
> > > support, so that installing can redirect the directory if desired. That's used
> > > for the tmp_install/ installation now.
> > >
> > > I didn't like the number of arguments necessary for install_test_files, so I
> > > changed it to use
> > >
> > > --install target list of files
> > >
> > > which makes it easier to use for further directories, if/when we need them.
> > >
> >
> > So if I understand this right, the way to use this would be something
> > like:
> >
> >
> >     local $ENV{DESTDIR} = $installdir;
> >
> >     run_log("meson compile -C $pgsql install-test-files");
> >
> >
> > Is that right? I did that but it didn't work :-(

Bilal's explanation of why that doesn't work was right. You'd only want to use
DESTDIR to install into somewhere other than the real install path.

> OK, tried without the `local` line and it worked, so let's push this.

Done. It's possible that we might some more refinement here, but I thought
it important to unblock the buildfarm work...

Greetings,

Andres Freund