From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
Cc: | Melanie Plageman <melanieplageman(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Should vacuum process config file reload more often |
Date: | 2023-03-02 00:15:35 |
Message-ID: | 20230302001535.fnyjmg6abc6gyflw@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2023-02-28 11:16:45 +0900, Masahiko Sawada wrote:
> On Tue, Feb 28, 2023 at 10:21 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
> > On 2023-02-27 23:11:53 +0900, Masahiko Sawada wrote:
> > > As far as I know there are not such GUC parameters in the core but
> > > there might be in third-party table AM and index AM extensions.
> >
> > We already reload in a pretty broad range of situations, so I'm not sure
> > there's a lot that could be unsafe that isn't already.
> >
> >
> > > Also, I'm concerned that allowing to change any GUC parameters during
> > > vacuum/analyze could be a foot-gun in the future. When modifying
> > > vacuum/analyze-related codes, we have to consider the case where any GUC
> > > parameters could be changed during vacuum/analyze.
> >
> > What kind of scenario are you thinking of?
>
> For example, I guess we will need to take care of changes of
> maintenance_work_mem. Currently we initialize the dead tuple space at
> the beginning of lazy vacuum, but perhaps we would need to
> enlarge/shrink it based on the new value?
I don't think we need to do anything about that initially, just because the
config can be changed in a more granular way, doesn't mean we have to react to
every change for the current operation.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2023-03-02 00:22:19 | Re: Making empty Bitmapsets always be NULL |
Previous Message | Andres Freund | 2023-03-02 00:14:30 | Re: Non-superuser subscription owners |