| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Corey Huinker <corey(dot)huinker(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: verbose mode for pg_input_error_message? |
| Date: | 2023-02-25 23:29:19 |
| Message-ID: | 20230225232919.GA1026327@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Feb 25, 2023 at 01:39:21PM +0900, Michael Paquier wrote:
> pg_input_error_message() does not strike me as a good function name,
> though, because it now returns much more than an error message.
> Hence, couldn't something like pg_input_error() be better, because
> more generic?
I personally think the existing name is fine. It returns the error
message, which includes the primary, detail, and hint messages. Also, I'm
not sure that pg_input_error() is descriptive enough. That being said, I'm
happy to run the sed command to change the name to whatever folks think is
best.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-26 01:07:33 | Re: verbose mode for pg_input_error_message? |
| Previous Message | Justin Pryzby | 2023-02-25 22:45:38 | Re: windows/meson cfbot warnings |