| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, David Rowley <dgrowleyml(at)gmail(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: ExecRTCheckPerms() and many prunable partitions (checkAsUser) |
| Date: | 2023-02-20 15:19:13 |
| Message-ID: | 20230220151913.hms7msl5bs3tpwxj@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-Feb-20, Amit Langote wrote:
> On Fri, Feb 17, 2023 at 9:02 PM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
> > I tried a few things for a new test case, but I was unable to find
> > anything useful. Maybe an intermediate view, I thought; no dice.
> > Maybe one with a security barrier would do? Anyway, for now I just kept
> > what you added in v2.
>
> Hmm, I'm fine with leaving the test case out if it doesn't really test
> the code we're changing, as you also pointed out?
Yeah, pushed like that.
> One more thing we could try is come up with a postgres_fdw test case,
> because it uses the RelOptInfo.userid value for remote-costs-based
> path size estimation. But adding a test case to contrib module's
> suite test a core planner change might seem strange, ;-).
Maybe. Perhaps adding it in a separate file there is okay?
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Small aircraft do not crash frequently ... usually only once!"
(ponder, http://thedailywtf.com/)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Markur Sens | 2023-02-20 15:25:23 | pg_crc32c_armv8.c:35:9: error: implicit declaration of function '__crc32cb' is invalid in C99 |
| Previous Message | David G. Johnston | 2023-02-20 15:17:02 | Re: Improving inferred query column names |