| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, thomas(dot)munro(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, john(dot)naylor(at)enterprisedb(dot)com, noriyoshi(dot)shinoda(at)hpe(dot)com, jchampion(at)timescale(dot)com, sawada(dot)mshk(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)postgresql(dot)org, rjuju123(at)gmail(dot)com |
| Subject: | Re: Improve logging when using Huge Pages |
| Date: | 2023-02-13 23:22:45 |
| Message-ID: | 20230213232245.GI1653@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Feb 09, 2023 at 11:29:09AM -0800, Nathan Bossart wrote:
> On Thu, Feb 09, 2023 at 10:40:13AM +0100, Alvaro Herrera wrote:
> > On 2023-Feb-08, Justin Pryzby wrote:
> >> I don't think it makes sense to run postgres -C huge_pages_active,
> >> however, so I see no issue that that would always returns "false".
> >
> > Hmm, I would initialize it to return "unknown" rather than "off" — and
> > make sure it turns "off" at the appropriate time. Otherwise you're just
> > moving the confusion elsewhere.
>
> I think this approach would address my concerns about using a GUC.
Done that way. This also fixes the logic in win32_shmem.c.
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-add-GUC-huge_pages_active.patch | text/x-diff | 7.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2023-02-13 23:37:33 | Re: recovery modules |
| Previous Message | Jacob Champion | 2023-02-13 23:22:11 | [PATCH] Fix unbounded authentication exchanges during PQconnectPoll() |