From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Dmitry Dolgov <9erthalion6(at)gmail(dot)com> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Sergei Kornilov <sk(at)zsrv(dot)org>, Michael Paquier <michael(at)paquier(dot)xyz>, Marcos Pegoraro <marcos(at)f10(dot)com(dot)br>, vignesh C <vignesh21(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Pavel Trukhanov <pavel(dot)trukhanov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Subject: | Re: pg_stat_statements and "IN" conditions |
Date: | 2023-02-09 17:26:51 |
Message-ID: | 20230209172651.cfgrebpyyr72h7fv@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-Feb-09, Dmitry Dolgov wrote:
> > On Thu, Feb 09, 2023 at 02:30:34PM +0100, Peter Eisentraut wrote:
> > What is the point of making this a numeric setting? Either you want
> > to merge all values or you don't want to merge any values.
>
> At least in theory the definition of "too many constants" is different
> for different use cases and I see allowing to configure it as a way of
> reducing the level of surprise here.
I was thinking about this a few days ago and I agree that we don't
necessarily want to make it just a boolean thing; we may want to make it
more complex. One trivial idea is to make it group entries in powers of
10: for 0-9 elements, you get one entry, and 10-99 you get a different
one, and so on:
# group everything in a single bucket
const_merge_threshold = true / yes / on
# group 0-9, 10-99, 100-999, 1000-9999
const_merge_treshold = powers
Ideally the value would be represented somehow in the query text. For
example
query | calls
----------------------------------------------------------+-------
select * from test where i in ({... 0-9 entries ...}) | 2
select * from test where i in ({... 10-99 entries ...}) | 1
What do you think? The jumble would have to know how to reduce all
values within each power-of-ten group to one specific value, but I don't
think that should be particularly difficult.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Find a bug in a program, and fix it, and the program will work today.
Show the program how to find and fix a bug, and the program
will work forever" (Oliver Silfridge)
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2023-02-09 18:16:45 | Re: MacOS: xsltproc fails with "warning: failed to load external entity" |
Previous Message | Nathan Bossart | 2023-02-09 17:24:58 | Re: recovery modules |