| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: recovery modules |
| Date: | 2023-02-01 21:06:06 |
| Message-ID: | 20230201210606.nvfbuvzfby3gskvu@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2023-02-01 12:15:29 -0800, Nathan Bossart wrote:
> Here's a new patch set in which I've attempted to address this feedback and
> Michael's feedback.
Looks better!
> @@ -25,12 +34,14 @@ extern PGDLLIMPORT char *XLogArchiveLibrary;
> * For more information about the purpose of each callback, refer to the
> * archive modules documentation.
> */
> -typedef bool (*ArchiveCheckConfiguredCB) (void);
> -typedef bool (*ArchiveFileCB) (const char *file, const char *path);
> -typedef void (*ArchiveShutdownCB) (void);
> +typedef void (*ArchiveStartupCB) (ArchiveModuleState *state);
> +typedef bool (*ArchiveCheckConfiguredCB) (ArchiveModuleState *state);
> +typedef bool (*ArchiveFileCB) (const char *file, const char *path, ArchiveModuleState *state);
> +typedef void (*ArchiveShutdownCB) (ArchiveModuleState *state);
Personally I'd always pass ArchiveModuleState *state as the first arg,
but it's not important.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-02-01 21:12:13 | Re: pg_dump versus hash partitioning |
| Previous Message | Andres Freund | 2023-02-01 21:02:29 | Re: Non-superuser subscription owners |