| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | kuroda(dot)hayato(at)fujitsu(dot)com |
| Cc: | amit(dot)kapila16(at)gmail(dot)com, osumi(dot)takamichi(at)fujitsu(dot)com, smithpb2250(at)gmail(dot)com, vignesh21(at)gmail(dot)com, shveta(dot)malik(at)gmail(dot)com, dilipbalaut(at)gmail(dot)com, euler(at)eulerto(dot)com, m(dot)melihmutlu(at)gmail(dot)com, andres(at)anarazel(dot)de, marcos(at)f10(dot)com(dot)br, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Time delayed LR (WAS Re: logical replication restrictions) |
| Date: | 2023-01-31 08:10:46 |
| Message-ID: | 20230131.171046.430789655878869142.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Kuroda-san, Thanks for the detailed study.
At Tue, 31 Jan 2023 07:06:40 +0000, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> wrote in
> Therefore, I think we can say that modern platforms that are supported by PostgreSQL define int as 32-bit.
> It satisfies the condition sizeof(int) <= sizeof(int32), so we can keep to use INT_MAX.
Yeah, I know that that's practically correct. Just I wanted to make
clear is whether we (always) assume int == int32. I don't want to do
that just because that works. Even though we cannot be perfect, in
this particular case the destination space is explicitly made as
int32.
It's a similar discussion to the recent commit 3b4ac33254. We choosed
to use the "correct" symbols refusing to employ an implicit assumption
about the actual values. (In that sense, it is a compromize to assume
int32 being narrower than int is a premise, but the code will get
uselessly complex without that assumption:p)
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-01-31 08:44:03 | Re: meson: Optionally disable installation of test modules |
| Previous Message | Joel Jacobson | 2023-01-31 07:59:22 | Re: [PATCH] Fix old thinko in formula to compute sweight in numeric_sqrt(). |