| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Date: | 2023-01-25 22:37:04 |
| Message-ID: | 20230125223704.GA1164580@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Jan 25, 2023 at 04:50:22PM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> I wanted to merge basic_archive and basic_recovery because there's a decent
>> chunk of duplicated code.
>
> Would said code likely be duplicated into non-test uses of this feature?
> If so, maybe you ought to factor it out into a common location. I agree
> with Robert's point that basic_wal_module is a pretty content-free name.
I doubt it. The duplicated parts are things like _PG_init(), the check
hook for the GUC, and all the rest of the usual boilerplate stuff for
extensions (e.g., Makefile, meson.build). This module is small enough that
this probably makes up the majority of the code.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-01-25 22:41:18 | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Previous Message | Peter Geoghegan | 2023-01-25 22:33:45 | pgsql: Doc: update VACUUM VERBOSE freezing tip. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2023-01-25 22:41:18 | Re: pgsql: Rename contrib module basic_archive to basic_wal_module |
| Previous Message | Andres Freund | 2023-01-25 22:34:32 | Re: [PATCH] Make ON CONFLICT DO NOTHING and ON CONFLICT DO UPDATE consistent |