Re: pgindent vs variable declaration across multiple lines

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgindent vs variable declaration across multiple lines
Date: 2023-01-22 22:40:34
Message-ID: 20230122224034.ualo3fa6urh7g4la@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2023-01-22 17:34:52 -0500, Tom Lane wrote:
> I spent some more time staring at this and came up with what seems like
> a workable patch, based on the idea that what we want to indent is
> specifically initialization expressions.

That's awesome. Thanks for doing that.

> Proposed patch for pg_bsd_indent attached. I've also attached a diff
> representing the delta between what current pg_bsd_indent wants to do
> to HEAD and what this would do. All the changes it wants to make look
> good, although I can't say whether there are other places it's failing
> to change that we'd like it to.

I think it's a significant improvement, even if it turns out that there's
other cases it misses.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-01-22 22:47:37 Re: run pgindent on a regular basis / scripted manner
Previous Message Andres Freund 2023-01-22 22:38:06 Re: run pgindent on a regular basis / scripted manner