| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, justin(at)tonic(dot)ai, pgsql-bugs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: BUG #17753: pg_dump --if-exists bug |
| Date: | 2023-01-21 16:00:12 |
| Message-ID: | 20230121160012.GC1356297@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Thu, Jan 19, 2023 at 07:09:50PM -0500, Tom Lane wrote:
> I wrote:
> > I think we need to do the attached, more or less. Also, although the
> > given case seems to be new, we'd probably better back-patch, because
> > I'm not convinced that there aren't other ways to reach this.
>
> Ah --- we only need to back-patch to v15, because this business of
> possibly having a comment in the dropStmt is new in a7a7be1f2.
> That commit also added the existing exceptions for comments in
> pg_backup_archiver.c ... but it missed the need to have special
> cases for dropStmts too.
Your commit 74739d1 looks good. Thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2023-01-21 23:10:29 | Re: BUG #17757: Not honoring huge_pages setting during initdb causes DB crash in Kubernetes |
| Previous Message | Amit Kapila | 2023-01-21 11:36:14 | Re: DROP DATABASE deadlocks with logical replication worker in PG 15.1 |