Re: almost-super-user problems that we haven't fixed yet

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: almost-super-user problems that we haven't fixed yet
Date: 2023-01-19 19:46:01
Message-ID: 20230119194601.GA4105788@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Thu, Jan 19, 2023 at 02:17:35PM -0500, Robert Haas wrote:
> On Thu, Jan 19, 2023 at 12:54 PM Nathan Bossart
> <nathandbossart(at)gmail(dot)com> wrote:
>> > OK. Might be worth a short comment.
>> I added one.
> Thanks. I'd move it to the inner indentation level so it's closer to
> the test at issue.

I meant for it to cover the call to HaveNFreeProcs() as well since the same
idea applies. I left it the same for now, but if you still think it makes
sense to move it, I'll do so.

> I would also suggest reordering the documentation and the
> postgresql.conf.sample file so that reserved_connections precedes
> superuser_reserved_connections, instead of following it.

Makes sense.

> Other than that, this seems like it might be about ready to commit,
> barring objections or bug reports.


Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v5-0001-Code-review-for-ea92368.patch text/x-diff 1.6 KB
v5-0002-Rename-ReservedBackends-to-SuperuserReservedConne.patch text/x-diff 4.1 KB
v5-0003-Introduce-reserved_connections-and-pg_use_reserve.patch text/x-diff 13.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-01-19 20:12:12 Re: Decoupling antiwraparound autovacuum from special rules around auto cancellation
Previous Message Tom Lane 2023-01-19 19:39:26 Re: generic plans and "initial" pruning