| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, postgresql(at)taljaren(dot)se, pgsql-hackers(at)lists(dot)postgresql(dot)org, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |
| Date: | 2022-12-28 21:12:53 |
| Message-ID: | 20221228211253.GA4009571@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On Wed, Dec 28, 2022 at 03:13:23PM -0500, Tom Lane wrote:
> I'm forced to the conclusion that we have to expose some VACUUM
> options if we want this to work well. Attached is a draft patch
> that invents SKIP_DATABASE_STATS and ONLY_DATABASE_STATS options
> (name bikeshedding welcome) and teaches vacuumdb to use them.
This is the conclusion I arrived at, too. In fact, I was just about to
post a similar patch set. I'm attaching it here anyway, but I'm fine with
proceeding with your version.
I think the main difference between your patch and mine is that I've
exposed vac_update_datfrozenxid() via a function instead of a VACUUM
option. IMHO that feels a little more natural, but I can't say I feel too
strongly about it.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-add-UPDATE_DATFROZENXID-option-to-VACUUM.patch | text/x-diff | 6.2 KB |
| v1-0002-introduce-pg_update_datfrozenxid.patch | text/x-diff | 5.2 KB |
| v1-0003-update-datfrozenxid-datminmxid-once-per-database-.patch | text/x-diff | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-12-28 21:20:19 | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |
| Previous Message | Tom Lane | 2022-12-28 20:13:23 | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-12-28 21:20:19 | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |
| Previous Message | Tom Lane | 2022-12-28 20:13:23 | Re: BUG #17717: Regression in vacuumdb (15 is slower than 10/11 and possible memory issue) |