Re: Add sub-transaction overflow status in pg_stat_activity

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Bruce Momjian <bruce(at)momjian(dot)us>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Add sub-transaction overflow status in pg_stat_activity
Date: 2022-12-12 17:42:02
Message-ID: 20221212174202.GF27893@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 12, 2022 at 09:33:51AM -0800, Nathan Bossart wrote:
> On Mon, Dec 12, 2022 at 11:15:43AM -0500, Robert Haas wrote:
> > Any strenuous objections?
>
> Nope. In fact, +1. Until more work is done to alleviate the performance
> issues, this information will likely prove useful.

The docs could use a bit of attention. Otherwise +1.

diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgml
index 4efa1d5fca0..ac15e2ce789 100644
--- a/doc/src/sgml/monitoring.sgml
+++ b/doc/src/sgml/monitoring.sgml
@@ -5680,12 +5680,12 @@ FROM pg_stat_get_backend_idset() AS backendid;
<returnvalue>record</returnvalue>
</para>
<para>
- Returns a record of information about the backend's subtransactions.
- The fields returned are <parameter>subxact_count</parameter> identifies
- number of active subtransaction and <parameter>subxact_overflow
- </parameter> shows whether the backend's subtransaction cache is
- overflowed or not.
- </para></entry>
+ Returns a record of information about the subtransactions of the backend
+ with the specified ID.
+ The fields returned are <parameter>subxact_count</parameter>, which
+ identifies the number of active subtransaction and
+ <parameter>subxact_overflow</parameter>, which shows whether the
+ backend's subtransaction cache is overflowed or not.
</para></entry>
</row>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-12-12 17:51:42 Re: Add sub-transaction overflow status in pg_stat_activity
Previous Message Robert Haas 2022-12-12 17:41:58 Re: Minimal logical decoding on standbys