Re: Generate pg_stat_get_* functions with Macros

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Generate pg_stat_get_* functions with Macros
Date: 2022-12-10 03:55:45
Message-ID: 20221210035545.GA196116@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Dec 09, 2022 at 09:43:56PM -0500, Tom Lane wrote:
> Presumably it could be silenced by removing the semicolons after
> the new macro calls:

> The backslash after the last right brace means that the line
> following that is part of the macro body. This does no harm as
> long as said line is blank ... but I think it's a foot-gun
> waiting to bite somebody, because visually you'd think the macro
> ends with the brace. So I'd leave off that last backslash.

Indeed. Patch attached.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
fix_pgstat.patch text/x-diff 7.2 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-12-10 04:01:56 Re: slab allocator performance issues
Previous Message Michael Paquier 2022-12-10 03:52:16 Re: Generate pg_stat_get_* functions with Macros