Re: Eliminating SPI from RI triggers - take 2

Hi,

On 2022-10-15 14:47:05 +0900, Amit Langote wrote:
> Attached updated patches.

These started to fail to build recently:

[04:43:33.046] ccache cc -Isrc/backend/postgres_lib.a.p -Isrc/include -I../src/include -Isrc/include/storage -Isrc/include/utils -Isrc/include/catalog -Isrc/include/nodes -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -fno-strict-aliasing -fwrapv -fexcess-precision=standard -D_GNU_SOURCE -Wmissing-prototypes -Wpointer-arith -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -Wdeclaration-after-statement -Wno-format-truncation -Wno-stringop-truncation -fPIC -pthread -DBUILDING_DLL -MD -MQ src/backend/postgres_lib.a.p/executor_execPartition.c.o -MF src/backend/postgres_lib.a.p/executor_execPartition.c.o.d -o src/backend/postgres_lib.a.p/executor_execPartition.c.o -c ../src/backend/executor/execPartition.c
[04:43:33.046] ../src/backend/executor/execPartition.c: In function ‘ExecGetLeafPartitionForKey’:
[04:43:33.046] ../src/backend/executor/execPartition.c:1679:19: error: too few arguments to function ‘build_attrmap_by_name_if_req’
[04:43:33.046] 1679 | AttrMap *map = build_attrmap_by_name_if_req(RelationGetDescr(root_rel),
[04:43:33.046] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
[04:43:33.046] In file included from ../src/include/access/tupconvert.h:17,
[04:43:33.046] from ../src/include/nodes/execnodes.h:32,
[04:43:33.046] from ../src/include/executor/execPartition.h:16,
[04:43:33.046] from ../src/backend/executor/execPartition.c:21:
[04:43:33.046] ../src/include/access/attmap.h:47:17: note: declared here
[04:43:33.046] 47 | extern AttrMap *build_attrmap_by_name_if_req(TupleDesc indesc,
[04:43:33.046] | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~

Regards,

Andres