| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Missing update of all_hasnulls in BRIN opclasses |
| Date: | 2022-11-29 20:38:08 |
| Message-ID: | 20221129203808.GB24131@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 28, 2022 at 01:13:14AM +0100, Tomas Vondra wrote:
> Opinions? Considering this will need to be backpatches, it'd be good to
> get some feedback on the approach. I think it's fine, but it would be
> unfortunate to fix one issue but break BRIN in a different way.
> --- a/contrib/pageinspect/Makefile
> +++ b/contrib/pageinspect/Makefile
> @@ -22,7 +22,7 @@ DATA = pageinspect--1.10--1.11.sql \
> pageinspect--1.0--1.1.sql
> PGFILEDESC = "pageinspect - functions to inspect contents of database pages"
>
> -REGRESS = page btree brin gin gist hash checksum oldextversions
> +REGRESS = page btree brin gin gist hash checksum oldextversions brinbugs
I can't comment on the patch itself, but:
These changes to ./Makefile will also need to be made in ./meson.build.
Also (per cirrusci), the test sometimes fail since two parallel tests
are doing "CREATE EXTENSION".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-11-29 20:46:07 | Re: Slow standby snapshot |
| Previous Message | Daniel Gustafsson | 2022-11-29 20:32:34 | Re: User functions for building SCRAM secrets |