Re: Proposal: Allow user with pg_monitor role to call pg_stat_reset* functions

From: Andres Freund <andres(at)anarazel(dot)de>
To: sirisha chamarthi <sirichamarthi22(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Proposal: Allow user with pg_monitor role to call pg_stat_reset* functions
Date: 2022-11-21 20:45:39
Message-ID: 20221121204539.wpfm2yntlhqr3jzk@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-11-21 00:16:20 -0800, sirisha chamarthi wrote:
> At present, calling pg_stat_reset* functions requires super user access
> unless explicitly grant execute permission on those. In this thread, I am
> proposing to grant execute on them to users with pg_monitor role
> permissions. This comes handy to the monitoring users (part of pg_monitor
> role) to capture the stats fresh and analyze. Do you see any concerns with
> this approach?

I think the common assumption is that a monitoring role cannot modify
the system, but this would change that. Normally a monitoring tool
should be able to figure out what changed in stats by comparing values
across time, rather than resetting stats.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-11-21 20:47:38 Re: Proposal: Allow user with pg_monitor role to call pg_stat_reset* functions
Previous Message Andres Freund 2022-11-21 20:40:49 Re: Understanding WAL - large amount of activity from removing data