| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, alvherre(at)alvh(dot)no-ip(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Suppressing useless wakeups in walreceiver |
| Date: | 2022-11-16 04:24:16 |
| Message-ID: | 20221116042416.GA102089@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 16, 2022 at 04:57:08PM +1300, Thomas Munro wrote:
> On Tue, Nov 15, 2022 at 5:49 PM Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>> Another option might be to just force initial reply/feedback messages when
>> streaming starts. The attached patch improves src/test/recovery test
>> runtime just like the previous one I posted.
>
> Yeah, looks good in my tests. I think we just need to make it
> conditional so we don't force it if someone has
> wal_receiver_status_interval disabled.
Yeah, that makes sense. IIUC setting "force" to false would have the same
effect for the initial round of streaming, but since writePtr/flushPtr will
be set in later rounds, no reply would be guaranteed. That might be good
enough for the tests, but it seems a bit inconsistent. So, your patch is
probably the way to go.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dilip Kumar | 2022-11-16 04:26:15 | Re: SUBTRANS: Minimizing calls to SubTransSetParent() |
| Previous Message | Jeff Davis | 2022-11-16 04:09:34 | Re: Add test module for Custom WAL Resource Manager feature |