Re: predefined role(s) for VACUUM and ANALYZE

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Corey Huinker <corey(dot)huinker(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: predefined role(s) for VACUUM and ANALYZE
Date: 2022-11-14 23:40:04
Message-ID: 20221114234004.GA1771874@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Oct 14, 2022 at 07:37:38PM -0400, Corey Huinker wrote:
> Patch applies.
> Passes make check and make check-world.
> Test coverage seems adequate.
> Coding is very clear and very much in the style of the existing code. Any
> quibbles I have with the coding style are ones I have with the overall
> pg-style, and this isn't the forum for that.
> I haven't done any benchmarking yet, but it seems that the main question
> will be the impact on ordinary DML statements.
> I have no opinion about the design debate earlier in this thread, but I do
> think that this patch is ready and adds something concrete to the ongoing
> discussion.

Thanks for taking a look! Here is a rebased version of the patch set.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v8-0001-Change-AclMode-from-a-uint32-to-a-uint64.patch text/x-diff 7.4 KB
v8-0002-Simplify-WARNING-messages-emitted-when-skipping-v.patch text/x-diff 15.8 KB
v8-0003-Allow-granting-VACUUM-and-ANALYZE-privileges-on-r.patch text/x-diff 38.9 KB
v8-0004-Add-pg_vacuum_all_tables-and-pg_analyze_all_table.patch text/x-diff 9.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-11-14 23:46:55 Re: Allow file inclusion in pg_hba and pg_ident files
Previous Message Thomas Munro 2022-11-14 23:26:00 Re: Suppressing useless wakeups in walreceiver