|From:||Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>|
|To:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|Cc:||pgsql-hackers(at)postgresql(dot)org, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>|
|Subject:||Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
On Wed, 09 Nov 2022 11:17:29 -0500
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp> writes:
> > Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> What do you think of the attached wording?
> > It looks good to me. That describes the expected behaviour exactly.
> Pushed that, then.
> >> I don't think the pipeline angle is of concern to anyone who might be
> >> reading these comments with the aim of understanding what guarantees
> >> they have. Perhaps there should be more about that in the user-facing
> >> docs, though.
> > I agree with that we don't need to mention pipelining in these comments,
> > and that we need more in the documentation. I attached a doc patch to add
> > a mention of commands that do internal commit to the pipelining section.
> > Also, this adds a reference for the pipelining protocol to the libpq doc.
> Hmm ... I don't really find either of these changes to be improvements.
> The fact that, say, multi-table ANALYZE uses multiple transactions
> seems to me to be a property of that statement, not of the protocol.
Ok. Then, if we want to notice users that commands using internal commits
could unexpectedly close a transaction in pipelining, the proper place is
Yugo NAGATA <nagata(at)sraoss(dot)co(dot)jp>
|Next Message||Yugo NAGATA||2022-11-10 05:48:59||Re: BUG #17434: CREATE/DROP DATABASE can be executed in the same transaction with other commands|
|Previous Message||Daisuke Higuchi (Fujitsu)||2022-11-10 01:27:55||RE: BUG #17681: Building the REL_12_13 source in Visual Studio 2013 fails.|
|Next Message||Michael Paquier||2022-11-10 04:53:58||Re: Fix some newly modified tab-complete changes|
|Previous Message||Regina Obe||2022-11-10 04:44:07||RE: Ability to reference other extensions by schema in extension scripts|