| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | David Christensen <david(dot)christensen(at)crunchydata(dot)com> |
| Cc: | Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Date: | 2022-11-08 22:45:19 |
| Message-ID: | 20221108224519.GH3775@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Nov 07, 2022 at 05:01:01PM -0600, David Christensen wrote:
> Hi Justin et al,
>
> Enclosed is v5 of this patch which now passes the CirrusCI checks for
> all supported OSes. I went ahead and reworked the test a bit so it's a
> little more amenable to the OS-agnostic approach for testing.
Great, thanks.
This includes the changes that I'd started a few months ago.
Plus adding the test which was missing for meson.
+ format: <literal><replaceable>LSN</replaceable>.<replaceable>TSOID</replaceable>.<replaceable>DBOID</replaceable>.<replaceable>RELNODE</replaceable>.<replaceable>BLKNO</replaceable></literal>
I'd prefer if the abbreviations were "reltablespace" and "datoid"
Also, should the test case call pg_relation_filenode() rather than using
relfilenode directly ? Is it a problem that the test code assumes
pagesize=8192 ?
--
Justin
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Teach-pg_waldump-to-extract-FPIs-from-the-WAL-stream.patch | text/x-diff | 17.3 KB |
| 0002-f-justin.patch | text/x-diff | 10.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Christensen | 2022-11-08 22:49:19 | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Previous Message | Thomas Munro | 2022-11-08 22:42:36 | Re: Slow standby snapshot |