Re: allow segment size to be set to < 1GiB

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Peter Geoghegan <pg(at)bowt(dot)ie>
Subject: Re: allow segment size to be set to < 1GiB
Date: 2022-11-08 02:29:12
Message-ID: 20221108022912.f2j7e4y3nylruusj@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-11-07 12:52:25 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > In the attached patch I renamed --with-segsize= to --with-segsize-mb= /
> > -Dsegsize= to -Dsegsize_mb=, to avoid somebody building with --with-segsize=2
> > or such suddenly ending up with an incompatible build.
>
> For the purpose of exercising these code paths with the standard
> regression tests, even a megabyte seems large -- we don't create
> very many test tables that are that big.

Good point.

> How about instead allowing the segment size to be set in pages?

In addition or instead of --with-segsize/-Dsegsize? Just offering the number
of pages seems like a not great UI.

I guess we could add support for units or such? But that seems messy as well.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kyotaro Horiguchi 2022-11-08 02:33:53 Re: In-placre persistance change of a relation
Previous Message Andres Freund 2022-11-08 02:25:45 Re: Add palloc_aligned() to allow arbitrary power of 2 memory alignment