Re: Suppressing useless wakeups in walreceiver

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Cc: alvherre(at)alvh(dot)no-ip(dot)org, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, thomas(dot)munro(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Suppressing useless wakeups in walreceiver
Date: 2022-11-05 23:01:15
Message-ID: 20221105230115.GF137360@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Sat, Nov 05, 2022 at 03:00:55PM -0700, Nathan Bossart wrote:
> On Mon, Oct 17, 2022 at 03:21:18PM +0900, Kyotaro Horiguchi wrote:
>> Now that I see the fix for the implicit conversion:
>> L527: + nap = Max(0, (nextWakeup - now + 999) / 1000);
>> ..
>> L545: + (int) Min(INT_MAX, nap),
>> I think limiting the naptime at use is confusing. Don't we place these
>> adjacently? Then we could change the nap to an integer. Or we can
>> just assert out for the nap time longer than INT_MAX (but this would
>> require another int64 variable. I belive we won't need such a long
>> nap, (or that is no longer a nap?)
> Yeah, I guess this deserves a comment. I could also combine it easily:
> nap = (int) Min(INT_MAX, Max(0, (nextWakeup - now + 999) / 1000));

Here is a new version of the patch that addresses this feedback.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
v8-0001-Suppress-useless-wakeups-in-walreceiver.patch text/x-diff 10.4 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-11-06 02:38:19 Re: new option to allow pg_rewind to run without full_page_writes
Previous Message Nathan Bossart 2022-11-05 22:11:40 Re: Suppressing useless wakeups in walreceiver