| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, bharath(dot)rupireddyforpostgres(at)gmail(dot)com, tgl(at)sss(dot)pgh(dot)pa(dot)us, peter(dot)eisentraut(at)enterprisedb(dot)com, benoit(dot)lobreau(at)gmail(dot)com, alvherre(at)alvh(dot)no-ip(dot)org, robertmhaas(at)gmail(dot)com, bossartn(at)amazon(dot)com, david(at)pgmasters(dot)net, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)postgresql(dot)org, magnus(at)hagander(dot)net, sfrost(at)snowman(dot)net |
| Subject: | Re: archive modules |
| Date: | 2022-11-05 21:08:58 |
| Message-ID: | 20221105210858.GB137360@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 17, 2022 at 02:49:51PM +0900, Michael Paquier wrote:
> And, by the way, this patch would prevent the existence of archive
> modules that need to be loaded but *want* an archive_command with
> what they want to achieve. That does not strike me as a good idea if
> we want to have a maximum of flexibility with this facility.
Such a module could define a custom GUC that accepts a shell command. I
don't think we should overload the meaning of archive_command based on the
whims of whatever archive module is loaded. Besides the potential end-user
confusion, your archive_command might be unexpectedly used incorrectly if
you forget to set archive_library.
Perhaps we could eventually move the archive_command functionality to a
contrib module (i.e., "shell_archive") so that users must always set
archive_library. But until then, I suspect it's better to treat modules
and commands as two separate interfaces to ease migration from older major
versions (even though archive_command is now essentially a built-in archive
module).
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-11-05 21:39:03 | Re: Documentation for building with meson |
| Previous Message | Nathan Bossart | 2022-11-05 20:51:54 | Re: archive modules |