From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
---|---|
To: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, dean(dot)a(dot)rasheed(at)gmail(dot)com, er(at)xs4all(dot)nl, joel(at)compiler(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Schema variables - new implementation for Postgres 15 |
Date: | 2022-11-05 17:25:09 |
Message-ID: | 20221105172509.jevgf25hmtmu2c5s@jrouhaud |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On Sat, Nov 05, 2022 at 05:04:31PM +0100, Tomas Vondra wrote:
>
> I did a quick initial review of this patch series - attached is a
> version with "review" commits for some of the parts. The current patch
> seems in pretty good shape, most of what I noticed are minor issues. I
> plan to do a more thorough review later.
Thanks!
I agree with all of your comments, just a few answers below
> - NamesFromList and IdentifyVariable seem introduced unnecessarily
> early, as they are only used in 0002 and 0003 parts (in the original
> patch series). Not sure if the plan is to squash everything into a
> single patch, or commit individual patches.
The split was mostly done to make the patch easier to review, as it adds quite
a bit of infrastructure.
There have been some previous comments to have a more logical separation and
fix similar issues, but there are still probably other oddities like that
laying around. I personally didn't focus much on it as I don't know if the
future committer will choose to squash everything or not.
> - AFAIK patches don't need to modify typedefs.list.
I think this was discussed a year or so ago, and my understanding is that the
general rule is that it's now welcome, if not recommended, to maintain
typedefs.list in each patchset.
> Which I think means this:
>
> if (filter_lxid && svar->drop_lxid == MyProc->lxid)
> continue;
>
> accesses drop_lxid, which was not initialized in init_session_variable.
Agreed.
From | Date | Subject | |
---|---|---|---|
Next Message | Corey Huinker | 2022-11-05 17:39:09 | Re: pg_dump: Refactor code that constructs ALTER ... OWNER TO commands |
Previous Message | Tom Lane | 2022-11-05 16:39:14 | Re: [patch] Have psql's \d+ indicate foreign partitions |