From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
---|---|
To: | Andres Freund <andres(at)anarazel(dot)de> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Noah Misch <noah(at)leadboat(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Anastasia Lubennikova <lubennikovaav(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Daniel Gustafsson <daniel(at)yesql(dot)se>, samay sharma <smilingsamay(at)gmail(dot)com> |
Subject: | Re: CI and test improvements |
Date: | 2022-11-04 23:54:12 |
Message-ID: | 20221104235412.GE16921@telsasoft.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Sep 10, 2022 at 03:05:42PM -0500, Justin Pryzby wrote:
> On Sun, Aug 28, 2022 at 02:28:02PM -0700, Andres Freund wrote:
> > On 2022-08-28 12:10:29 -0500, Justin Pryzby wrote:
> > > On Sun, Aug 28, 2022 at 09:07:52AM -0700, Andres Freund wrote:
> > > > > --- /dev/null
> > > > > +++ b/src/tools/ci/windows-compiler-warnings
> > > >
> > > > Wouldn't that be doable as something like
> > > > sh -c 'if test -s file; then cat file;exit 1; fi"
> > > > inside .cirrus.yml?
> > >
> > > I had written it inline in a couple ways, like
> > > - sh -exc 'f=msbuild.warn.log; if [ -s "$f" ]; then cat "$f"; exit 1; else exit 0; fi'
> > >
> > > but then separated it out as you suggested in
> > > 20220227010908(dot)vz2a7dmfzgwg742w(at)alap3(dot)anarazel(dot)de
> > >
> > > after I complained about cmd.exe requiring escaping for && and ||
> > > That makes writing any shell script a bit perilous and a separate script
> > > seems better.
> >
> > I remember that I suggested it - but note that the way I wrote above doesn't
> > have anything needing escaping.
>
> It doesn't require it, but that still gives the impression that it's
> normally possible to write one-liner shell scripts there, which is
> misleading/wrong, and the reason why I took your suggestion to use a
> separate script file.
>
> > Anyway, what do you think of the multiline split I suggested?
>
> Done, and sorted.
Rewrote this and rebased some of the other stuff on top of the meson
commit, for which I also include some new patches.
Attachment | Content-Type | Size |
---|---|---|
0001-meson-PROVE-is-not-required.patch | text/x-diff | 1.2 KB |
0002-meson-other-fixes-for-cygwin.patch | text/x-diff | 2.5 KB |
0003-meson-rename-main-tasks-to-regress-and-isolation.patch | text/x-diff | 1.3 KB |
0004-cirrus-windows-add-compiler_warnings_script.patch | text/x-diff | 2.5 KB |
0005-cirrus-build-docs-as-a-separate-task.patch | text/x-diff | 2.9 KB |
0006-cirrus-ccache-add-explicit-cache-keys.patch | text/x-diff | 1.5 KB |
0007-cirrus-ccache-disable-compression-and-show-stats.patch | text/x-diff | 3.5 KB |
0008-cirrus-warnings-use-a-single-common-always-block.patch | text/x-diff | 3.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2022-11-05 00:38:28 | Re: Direct I/O |
Previous Message | Tom Lane | 2022-11-04 23:46:39 | Re: PL/pgSQL cursors should get generated portal names by default |