Re: Incorrect include file order in guc-file.l

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect include file order in guc-file.l
Date: 2022-11-02 06:01:05
Message-ID: 20221102060105.o5raimiuo2aopv4r@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Nov 02, 2022 at 02:29:50PM +0900, Michael Paquier wrote:
>
> While reviewing a different patch, I have noticed that guc-file.l
> includes sys/stat.h in the middle of the PG internal headers. The
> usual practice is to have first postgres[_fe].h, followed by the
> system headers and finally the internal headers. That's a nit, but
> all the other files do that.
>
> {be,fe}-secure-openssl.c include some exceptions though, as documented
> there.

Agreed, it's apparently an oversight in dac048f71eb. +1 for the patch.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-11-02 06:24:11 Re: Improve description of XLOG_RUNNING_XACTS
Previous Message 吴亚飞 2022-11-02 05:56:36 spinlock support on loongarch64