Re: [patch] Have psql's \d+ indicate foreign partitions

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [patch] Have psql's \d+ indicate foreign partitions
Date: 2022-10-27 07:12:21
Message-ID: 20221027071221.h7fyzgosci53lk6l@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Oct-24, Justin Pryzby wrote:

> On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote:

> > + else if (child_relkind == RELKIND_FOREIGN_TABLE && is_partitioned)
> > + appendPQExpBuffer(&buf, ", server: \"%s\"", PQgetvalue(result, i, 4));

> To avoid the clutter that you mentioned, I suggest that this should show
> that the table *is* foreign, but without the server - if you want to
> know the server (or its options), you can run another \d command for
> that (or run a SQL query).

But 'server "%s"' is not much longer than "foreign", and it's not like
your saving any vertical space at all (you're just using space that
would otherwise be empty), so I'm not sure it is better. I would vote
for showing the server.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"You don't solve a bad join with SELECT DISTINCT" #CupsOfFail
https://twitter.com/connor_mc_d/status/1431240081726115845

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-10-27 07:23:53 Re: Simplifying our Trap/Assert infrastructure
Previous Message Bharath Rupireddy 2022-10-27 06:32:21 Re: Adding doubly linked list type which stores the number of items in the list