Re: make_ctags: use -I option to ignore pg_node_attr macro

From: Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp>
To: nagata(at)sraoss(dot)co(dot)jp
Cc: alvherre(at)alvh(dot)no-ip(dot)org, pgsql-hackers(at)postgresql(dot)org
Subject: Re: make_ctags: use -I option to ignore pg_node_attr macro
Date: 2022-10-19 04:25:17
Message-ID: 20221019.132517.1083262091188312375.t-ishii@sranhm.sra.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> Hi,
>
> On Sat, 15 Oct 2022 10:40:29 +0900 (JST)
> Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>
>> > On Thu, 13 Oct 2022 15:35:09 +0900 (JST)
>> > Tatsuo Ishii <ishii(at)sraoss(dot)co(dot)jp> wrote:
>> >
>> >> > OK, that sounds good then. I would make a feature request to have a
>> >> > switch that supresses creation of these links, then.
>> >>
>> >> Ok, I have added "-n" option to make_ctags so that it skips to create
>> >> the links.
>> >>
>> >> Also I have changed make_etags so that it exec make_ctags, which seems
>> >> to be the consensus.
>> >
>> > Thank you for following up my patch.
>> > I fixed the patch to allow use both -e and -n options together.
>>
>> Thanks. I have made mostly cosmetic changes so that it is more
>> consistent with existing scripts.
>>
>> I would like to push v6 patch if there's no objection.
>
> I am fine with this patch.

Thanks. the v6 patch pushed to master branch.

> By the way, in passing, how about adding "tags" and "TAGS" to
> .gitignore file?

Sounds like a good idea.

Best reagards,
--
Tatsuo Ishii
SRA OSS LLC
English: http://www.sraoss.co.jp/index_en/
Japanese:http://www.sraoss.co.jp

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yugo NAGATA 2022-10-19 04:29:25 Re: make_ctags: use -I option to ignore pg_node_attr macro
Previous Message Masahiko Sawada 2022-10-19 04:09:35 Re: TRAP: FailedAssertion("prev_first_lsn < cur_txn->first_lsn", File: "reorderbuffer.c", Line: 927, PID: 568639)