| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Junwang Zhao <zhjwpku(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [meson] add missing pg_attribute_aligned for MSVC in meson build |
| Date: | 2022-10-15 19:02:14 |
| Message-ID: | 20221015190214.uy367sq6mulqzs7w@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-10-14 10:59:28 +0800, Junwang Zhao wrote:
> Commit ec3c9cc add pg_attribute_aligned in MSVC[1],
> which was pushed one day before the meson commits,
> so meson build missed this feature.
Good catch. It shouldn't have practical consequences for the moment, given
that msvc doesn't support 128bit integers, but of course we should still be
correct.
Looked through other recent changes to configure and found a few additional
omissions.
See the attached patch fixing those omissions. I'll push it to HEAD once it
has the CI stamp of approval.
Greetings,
Andres Freund
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-meson-catch-up-to-a-few-configure-changes.patch | text/x-diff | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-15 19:10:00 | Re: [RFC] building postgres with meson - v13 |
| Previous Message | Tomas Vondra | 2022-10-15 15:23:54 | Re: PATCH: Using BRIN indexes for sorted output |