| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, bt22nakamorit <bt22nakamorit(at)oss(dot)nttdata(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Fix error message for MERGE foreign tables |
| Date: | 2022-10-14 09:24:06 |
| Message-ID: | 20221014092406.4qjatjwvrgialndz@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Actually, I hadn't realized that the originally submitted patch had the
test in postgres_fdw only, but we really want it to catch any FDW, so it
needs to be somewhere more general. The best place I found to put this
test is in make_modifytable ... I searched for some earlier place in the
planner to do it, but couldn't find anything.
So what do people think about this?
--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"La grandeza es una experiencia transitoria. Nunca es consistente.
Depende en gran parte de la imaginación humana creadora de mitos"
(Irulan)
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Disallow-MERGE-cleanly-for-foreign-partitions.patch | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | houzj.fnst@fujitsu.com | 2022-10-14 09:29:32 | RE: Perform streaming logical transactions by background workers and parallel apply |
| Previous Message | houzj.fnst@fujitsu.com | 2022-10-14 09:08:13 | RE: Perform streaming logical transactions by background workers and parallel apply |