Re: create subscription - improved warning message

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: Peter Smith <smithpb2250(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: create subscription - improved warning message
Date: 2022-10-12 08:38:25
Message-ID: 20221012083825.6jbdljqigdav47wk@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Oct-12, Amit Kapila wrote:

> I think it is a good idea to expand the docs for this but note that
> there are multiple places that use a similar description. For example,
> see the description slot_name option: "When slot_name is set to NONE,
> there will be no replication slot associated with the subscription.
> This can be used if the replication slot will be created later
> manually. Such subscriptions must also have both enabled and
> create_slot set to false.". Then, we have a few places in the logical
> replication docs [1] that talk about creating the slot manually but
> didn't explain in detail the name or options to use. We might want to
> write a slightly bigger doc patch so that we can write the description
> in one place and give reference to the same at other places.

+1

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"Para tener más hay que desear menos"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-10-12 08:42:15 Re: Summary Sort workers Stats in EXPLAIN ANALYZE
Previous Message tachikake.ayaki@fujitsu.com 2022-10-12 08:33:43 Fix wrong syntax about CREATE_REPLICATION_SLOT