| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Suppressing useless wakeups in walreceiver |
| Date: | 2022-10-11 17:52:17 |
| Message-ID: | 20221011175217.GB1326442@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Oct 11, 2022 at 09:34:25AM +0530, Bharath Rupireddy wrote:
> now = t1;
> XLogWalRcvSendReply() /* say it ran for a minute or so for whatever reasons */
> XLogWalRcvSendHSFeedback() /* with patch walrecevier sends hot standby
> feedback more often without properly honouring
> wal_receiver_status_interval because the 'now' isn't actually the
> current time as far as that function is concerned, it is
> t1 + XLogWalRcvSendReply()'s time. */
>
> Well, is this really a problem? I'm not sure about that. Let's hear from others.
For this example, the feedback message would just be sent in the next loop
iteration instead.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-11 18:23:36 | Re: Mingw task for Cirrus CI |
| Previous Message | Nathan Bossart | 2022-10-11 17:40:59 | Re: use has_privs_of_role() for pg_hba.conf |