Re: meson PGXS compatibility

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: meson PGXS compatibility
Date: 2022-10-10 21:35:14
Message-ID: 20221010213514.avffuqxpl5asxtsm@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-10-05 13:07:10 -0700, Andres Freund wrote:
> 0004: solaris: Check for -Wl,-E directly instead of checking for gnu LD
>
> This allows us to get rid of the nontrivial detection of with_gnu_ld,
> simplifying meson PGXS compatibility. It's also nice to delete libtool.m4.
>
> I don't like the SOLARIS_EXPORT_DYNAMIC variable I invented. If somebody has
> a better idea...

A cleaner approach could be to add a LDFLAGS_BE and emit the -Wl,-E into it
from both configure and meson, solely based on whether -Wl,-E is supported. I
haven't verified cygwin, but on our other platforms that seems to do the right
thing.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2022-10-10 22:07:00 Re: [PATCH] Fix build with LLVM 15 or above
Previous Message Andres Freund 2022-10-10 21:22:28 Re: problems with making relfilenodes 56-bits