| From: | Julien Rouhaud <rjuju123(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Record SET session in VariableSetStmt |
| Date: | 2022-10-07 03:33:03 |
| Message-ID: | 20221007033303.ucpqmlqr66rqy6vg@jrouhaud |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Oct 07, 2022 at 10:30:28AM +0900, Michael Paquier wrote:
> On Thu, Oct 06, 2022 at 08:28:27PM +0800, Julien Rouhaud wrote:
> > If we move to a real jumbling of VariableSetStmt, we should keep the rules
> > consistent with the rest of the jumble code and ignore an explicit "SESSION" in
> > the original command.
>
> Hm, interesting bit, I should study more this area. So the query ID
> calculation actually only cares about the contents of the Nodes
> parsed, while the query string used is the one when the entry is
> created for the first time. It seems like the patch to add
> TransactionStmt nodes into the jumbling misses something here, as we'd
> still compile different query IDs depending on the query string itself
> for simple commands like BEGIN or COMMIT. I'll reply on the other
> thread about all that..
Ah, indeed we have different TransactionStmtKind for BEGIN and START!
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2022-10-07 03:41:13 | Re: Query Jumbling for CALL and SET utility statements |
| Previous Message | Nathan Bossart | 2022-10-07 03:27:11 | Re: use has_privs_of_role() for pg_hba.conf |