| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Subject: | Re: meson: Add support for building with precompiled headers |
| Date: | 2022-10-07 00:25:24 |
| Message-ID: | 20221007002524.ge2uq6tzecllo6of@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-10-06 09:06:42 +0200, Peter Eisentraut wrote:
> On 05.10.22 21:08, Andres Freund wrote:
> > This is a patch split off from the initial meson thread [1] as it's
> > functionally largely independent (as suggested in [2]).
> >
> > Using precompiled headers substantially speeds up building for windows, due to
> > the vast amount of headers included via windows.h. A cross build from
> > linux targetting mingw goes from
>
> These patches look ok to me. I can't really comment on the Windows details,
> but it sounds all reasonable.
Thanks for reviewing!
> Small issue:
>
> +override CFLAGS += -DFD_SETSIZE=1024
>
> (and similar)
>
> should be CPPFLAGS.
Pushed with that adjusted.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-07 00:27:06 | Re: Issue with pg_stat_subscription_stats |
| Previous Message | David Rowley | 2022-10-07 00:24:03 | Re: shadow variables - pg15 edition |