| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Move backup-related code to xlogbackup.c/.h |
| Date: | 2022-10-05 22:52:24 |
| Message-ID: | 20221005225224.GA267337@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Oct 05, 2022 at 03:22:01PM +0530, Bharath Rupireddy wrote:
>> On Tue, Oct 04, 2022 at 03:54:20PM -0700, Nathan Bossart wrote:
>> > I would suggest moving this to a separate prerequisite patch that can be
>> > reviewed independently from the patches that simply move code to a
>> > different file.
>
> I added the new functions in 0001 patch for ease of review.
Can we also replace the relevant code with calls to these functions in
0001? That way, we can more easily review the changes you are making to
this code separately from the large patch that just moves the code.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-10-05 23:20:38 | Re: Move backup-related code to xlogbackup.c/.h |
| Previous Message | David Rowley | 2022-10-05 22:50:27 | Re: shadow variables - pg15 edition |